Refactors minMaxWorkers from ModelInfo to WorkerPool #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes some of the data from the ModelInfo to the wlm. Specifically, it moves tracking of the min and max number of workers. It also starts turning the wlm.WorkerPool into a public representation of the management of a single model while the main wlm has all models. As part of this, some functionality is moved from the main wlm to the pool. In general, we should eventually not have part of the API be wlm.doSomething(model, ...) and some of it be wlm.model(model).doSomething(...). I favor the latter approach. Lastly, this also removes the concept of updating the model and then triggering model changed. I noticed the change only really affects the scaleModel, so it is simpler to just move those effects under scaleModel directly.
frankfliu
approved these changes
Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes some of the data from the ModelInfo to the wlm. Specifically, it
moves tracking of the min and max number of workers.
It also starts turning the wlm.WorkerPool into a public representation of the
management of a single model while the main wlm has all models. As part of this,
some functionality is moved from the main wlm to the pool. In general, we should
eventually not have part of the API be wlm.doSomething(model, ...) and some of
it be wlm.model(model).doSomething(...). I favor the latter approach.
Lastly, this also removes the concept of updating the model and then triggering
model changed. I noticed the change only really affects the scaleModel, so it is
simpler to just move those effects under scaleModel directly.