Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable method-signature-style TypeScript ESLint rule #1578

Closed
mattrunyon opened this issue Oct 16, 2023 · 1 comment · Fixed by #1584
Closed

Enable method-signature-style TypeScript ESLint rule #1578

mattrunyon opened this issue Oct 16, 2023 · 1 comment · Fixed by #1584
Assignees
@georgecwan
Labels
enhancement New feature or request

Comments

@mattrunyon
Copy link
Collaborator

https://typescript-eslint.io/rules/method-signature-style/

Using the property option makes TS a little stronger in its function signature checks compared to the method option. We should enable this rule in property mode (which is the default).
@mattrunyon mattrunyon added enhancement New feature or request triage Issue requires triage labels Oct 16, 2023
@mattrunyon mattrunyon mentioned this issue Oct 16, 2023
Merged
2 tasks
@vbabich vbabich removed the triage Issue requires triage label Oct 17, 2023
@vbabich vbabich added this to the October 2023 milestone Oct 17, 2023
@georgecwan georgecwan mentioned this issue Oct 19, 2023
Merged
georgecwan added a commit that referenced this issue Oct 26, 2023
@georgecwan
style: Enable method-signature-style TypeScript ESLint rule (#1584)
b065f1c 
Added method-signature-style rule to ESLint rules with default
`property` mode.

Resolves #1578

---------

Co-authored-by: georgecwan <[email protected]>
@bmingles
Copy link
Contributor

I created https://deephaven.atlassian.net/browse/DH-15867 to address this rule in Enterprise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@georgecwan georgecwan

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

style: Enable method-signature-style TypeScript ESLint rule georgecwan/web-client-ui
4 participants
@bmingles @vbabich @mattrunyon @georgecwan