Fixed tests (DH-18088)

deephaven · Jan 3, 2025 · f460a62 · f460a62
1 parent 56ee44c
commit f460a62
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 6 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/components/src/spectrum/picker/usePickerScrollOnOpen.test.ts b/packages/components/src/spectrum/picker/usePickerScrollOnOpen.test.ts
@@ -49,9 +49,14 @@ describe('usePickerScrollOnOpen', () => {
     expect(result.current.ref).toBe(mockUsePopoverOnScrollRefResult.ref);
   });
 
-  it.each([true, false])(
-    'should return a callback that calls popoverOnOpenChange and onOpenChange: %s',
-    isOpen => {
+  it.each([
+    [true, undefined],
+    [false, undefined],
+    [true, 'input'],
+    [false, 'input'],
+  ] as const)(
+    'should return a callback that calls popoverOnOpenChange and onOpenChange: %s, %s',
+    (isOpen, menuTrigger) => {
       const { result } = renderHook(() =>
         usePickerScrollOnOpen({
           getInitialScrollPosition,
@@ -60,12 +65,12 @@ describe('usePickerScrollOnOpen', () => {
         })
       );
 
-      result.current.onOpenChange(isOpen);
+      result.current.onOpenChange(isOpen, menuTrigger);
 
       expect(mockUsePopoverOnScrollRefResult.onOpenChange).toHaveBeenCalledWith(
         isOpen
       );
-      expect(onOpenChange).toHaveBeenCalledWith(isOpen);
+      expect(onOpenChange).toHaveBeenCalledWith(isOpen, menuTrigger);
     }
   );
 });
diff --git a/packages/components/src/spectrum/picker/usePickerScrollOnOpen.ts b/packages/components/src/spectrum/picker/usePickerScrollOnOpen.ts
@@ -14,7 +14,7 @@ export interface UsePickerScrollOnOpenOptions {
 
 export interface UsePickerScrollOnOpenResult<THtml extends HTMLElement> {
   ref: DOMRef<THtml>;
-  onOpenChange: (isOpen: boolean) => void;
+  onOpenChange: (isOpen: boolean, menuTrigger?: MenuTriggerAction) => void;
 }
 
 /**