fix: slider input default value #959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wusteven815
requested review from
a team and
dgodinez-dh
and removed request for
a team
dgodinez-dh
approved these changes
Oct 24, 2024
mattrunyon
reviewed
Oct 24, 2024
Comment on lines
+47
to
+52
| export type SerializedInputElementProps<T, V> = Omit< | ||
| T, | ||
| 'defaultValue' | 'value' | 'onChange' | ||
| > & { | ||
| /** The default value of the input */ | ||
| defaultValue?: string; | ||
| defaultValue?: V; |
There was a problem hiding this comment.
Why change this to a generic? What other value could defaultValue and value have that is valid except for string?
There was a problem hiding this comment.
number for slider and { start: number; end: number } for range slider
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
useDebouncedOnChange