fix: Remove replay_lock in use_table_listener
#749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That failed test was working locally for me. Not sure why it wasn't here |
mattrunyon
reviewed
Aug 16, 2024
| @@ -248,8 +248,6 @@ def test_table_listener(self): | |||
| ] | |||
| ) | |||
|
|
|||
| self.verify_table_replayed(static_table) | |||
There was a problem hiding this comment.
This is also related to the change? I think you mentioned you can't replay a static table now?
There was a problem hiding this comment.
It was that failed test, yeah, it It looks like this was definitely intentional, that do_replay should not enough to allow a listen on a static table. https://github.com/deephaven/deephaven-core/pull/5672/files#r1678018572
mattrunyon
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes
replay_lockdue to deephaven/deephaven-core#5672