Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: ui.checkbox #722

Merged
merged 10 commits into from
Aug 19, 2024
Merged

docs: ui.checkbox #722

merged 10 commits into from
Aug 19, 2024

Conversation

AkshatJawne
Copy link
Contributor

Closes #720

@AkshatJawne AkshatJawne self-assigned this Aug 9, 2024
Copy link
Contributor

@dsmmcken dsmmcken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Each of checkbox, checkbox group and list_view should cross link to each other with an explanation of when to use each. (individual checkbox, a set of related checkbox, a list of checkboxes that can be driven from a deephaven table)

Similar to in button how we mention the difference between it and action_button.

@AkshatJawne AkshatJawne requested a review from dsmmcken August 12, 2024 14:28
@AkshatJawne AkshatJawne requested a review from dsmmcken August 16, 2024 21:48

Checkbox allows users to select or mark a single item as selected.

If wanting to use multiple checkboxes, use `checkbox_group`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If wanting to use multiple checkboxes, use `checkbox_group`.
To use multiple checkboxes together, use the `checkbox_group` component.

We should come back and link this when we have the checkbox group component

@AkshatJawne AkshatJawne requested a review from dsmmcken August 19, 2024 16:10
plugins/ui/docs/components/checkbox.md Show resolved Hide resolved
plugins/ui/docs/components/checkbox.md Outdated Show resolved Hide resolved
@AkshatJawne AkshatJawne requested a review from dsmmcken August 19, 2024 17:36
dsmmcken
dsmmcken previously approved these changes Aug 19, 2024
@AkshatJawne AkshatJawne requested a review from dsmmcken August 19, 2024 18:11
@AkshatJawne AkshatJawne merged commit 0cb525e into deephaven:main Aug 19, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: ui.checkbox
3 participants