Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Initial set of type fixes #217

Merged
merged 6 commits into from
Feb 9, 2024
Merged

fix: Initial set of type fixes #217

merged 6 commits into from
Feb 9, 2024

Conversation

jnumainville
Copy link
Collaborator

Adds a first set of type fixes for deephaven.ui and plotly-express
Most of the fixes are of the following:
| None added to parameters that can take None
any to Any and callable to Callable
Added necessary args to Generator and dict types
Associated documentation

@jnumainville jnumainville requested a review from mofojed January 19, 2024 23:09
mofojed
mofojed requested changes Jan 25, 2024
View reviewed changes
Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't put the types in the docstrings, as we have them already in the code.

Need to resolve the issue on <3.10

plugins/plotly-express/src/deephaven/plot/express/__init__.py Outdated Show resolved Hide resolved
plugins/plotly-express/src/deephaven/plot/express/communication/DeephavenFigureListener.py Outdated Show resolved Hide resolved
@jnumainville jnumainville requested a review from mofojed January 25, 2024 22:48
mofojed
mofojed requested changes Jan 26, 2024
View reviewed changes
Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to fix 3.8 still, and one minor typo to fix

plugins/plotly-express/src/deephaven/plot/express/deephaven_figure/generate.py Outdated Show resolved Hide resolved
@jnumainville
Copy link
Collaborator Author

jnumainville commented Jan 26, 2024 •
edited
Loading

The 3.8 and 3.9 failures are due to a core change. Opened deephaven/deephaven-core#5075

mofojed
mofojed previously approved these changes Jan 29, 2024
View reviewed changes
@mofojed mofojed mentioned this pull request Feb 5, 2024
Merged
@jnumainville jnumainville requested a review from mofojed February 8, 2024 22:25
@jnumainville jnumainville merged commit 5c52488 into deephaven:main Feb 9, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mofojed mofojed mofojed approved these changes

Assignees

@jnumainville jnumainville

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jnumainville @mofojed