feat: Support lerna scopes in npm start #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmingles
force-pushed
the
202-lerna-scopes-npm-start
branch
from
d779791 to
5177c40
Compare
mofojed
reviewed
Jan 11, 2024
| @@ -0,0 +1 @@ | |||
| plugins/json/test/*.json | |||
There was a problem hiding this comment.
Why do we need to ignore these files?
There was a problem hiding this comment.
Formatting the test .json files breaks CI tests. I assume they are formatted to match the json content exactly, but I'm not actually sure how the tests work
There was a problem hiding this comment.
Can you add a comment in this ignore file to that effect then?
mofojed
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support lerna scopes in npm start
resolves #202