Skip to content

Commit

Permalink
fix: Deephaven express memory leak (#277)
Browse files Browse the repository at this point in the history
Fixes #179 

Tested by running a server with and without this fix and opening the
Memory dev tools tab. Then ran the code in the ticket. The tab without
this fix grew steadily in memory consumption over several minutes. The
tab with the fix stayed fairly consistent over the same period of time.
  • Loading branch information
mattrunyon authored Feb 20, 2024
1 parent 8d4255c commit ff6ad50
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ export class PlotlyExpressChartModel extends ChartModel {
figureUpdateEvent.columns.forEach(column => {
const columnData = chartData.getColumn(
column.name,
val => this.chartUtils.unwrapValue(val),
this.chartUtils.unwrapValue,
figureUpdateEvent
);
tableData[column.name] = columnData;
Expand Down

0 comments on commit ff6ad50

Please sign in to comment.