-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add multi-column support to UpdateBy
RollingFormula()
operator
#6143
Open
lbooker42
wants to merge
11
commits into
deephaven:main
Choose a base branch
from
lbooker42:lab-rolling-multi-formula
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,164
−365
Open
Changes from 5 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
265e334
Refactor to allow dynamic affectingColumns in the base class.
lbooker42 5c5294f
Working, tests passing but need more.
lbooker42 c8c87bd
Added support for multiple formulas per call, spotless.
lbooker42 b64b342
Addressed PR comments
lbooker42 66dff62
Corrected JavaDoc failure in RingBufferWindowConsumer
lbooker42 eaa2816
Addressed PR comments and added python implementation.
lbooker42 37298c4
Updated python tests.
lbooker42 efc533c
Minor updates.
lbooker42 c969c11
Refactor to use SelectColumn instead of FormulaColumn
lbooker42 b3a02fb
Aggregating ring buffer correction to reset cleared buffer to identit…
lbooker42 36756da
Change AggregatingRingBuffer code to be smarter about resetting to id…
lbooker42 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More opportunities to add
@Override
to this code.