Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "jpy vararg leak" #2111

Merged
merged 1 commit into from
Mar 22, 2022
Merged

Revert "jpy vararg leak" #2111

merged 1 commit into from
Mar 22, 2022

Conversation

niloc132
Copy link
Member

This fix seems to be causing JVM crashes in at least one deephaven2 test.
Reverts #2105

@niloc132 niloc132 added this to the Mar 2022 milestone Mar 22, 2022
@niloc132 niloc132 requested a review from devinrsmith March 22, 2022 16:56
@niloc132 niloc132 merged commit e8252bc into main Mar 22, 2022
@niloc132 niloc132 deleted the revert-2105-jpy-vararg-leak branch March 22, 2022 17:30
@github-actions github-actions bot locked and limited conversation to collaborators Mar 22, 2022
@devinrsmith
Copy link
Member

devinrsmith commented Mar 22, 2022

Note: this was reverted due to some sigsegs. Diagnosing now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants