Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable py-client-ticking tests #5899

Open
devinrsmith opened this issue Aug 5, 2024 · 5 comments · May be fixed by #5900
Open

Re-enable py-client-ticking tests #5899

devinrsmith opened this issue Aug 5, 2024 · 5 comments · May be fixed by #5900
Assignees
Labels
bug Something isn't working ci core Core development tasks devrel-watch DevRel team is watching
Milestone

Comments

@devinrsmith
Copy link
Member

py-client-ticking tests were disabled in #5893 due to CI disk space related failures; it's conceivable that py-client-ticking isn't to blame, and it's just the straw that breaks CIs disk. We should do further investigation into the amount of disk space used in CI in general and proceed as appropriate; to either reduce disk space across a wider range of tasks, or reduce the disk space of py-client-ticking tests if it is to blame.

@devinrsmith devinrsmith added bug Something isn't working triage labels Aug 5, 2024
@devinrsmith devinrsmith added this to the 0.36.0 milestone Aug 5, 2024
@devinrsmith devinrsmith self-assigned this Aug 5, 2024
@rcaudy rcaudy added ci core Core development tasks and removed triage labels Aug 5, 2024
@devinrsmith
Copy link
Member Author

@devinrsmith
Copy link
Member Author

devinrsmith commented Aug 5, 2024

The actual test image being created (deephaven/test-c-python-client-ticking-3.9-ubi-minimal:local-build) isn't too big:

image

The entrypoint code doesn't seem to be that big either:

$ docker run -it --name test --entrypoint bash deephaven/test-c-python-client-ticking-3.9-ubi-minimal:local-build                                                                         
[root@66992a12062f project]# source /project/                                                                                                                                                                        
3.9/        dep-wheels/ pyt-wheels/ tests/                                                                                                                                                                           
[root@66992a12062f project]# source /project/3.9/bin/activate                                                                                                                                                        
(3.9) [root@66992a12062f project]# df -h .                                                                                                                                                                           
Filesystem      Size  Used Avail Use% Mounted on                                                                                                                                                                     
/dev/sdb3       930G  683G  246G  74% /                                                                                                                                                                              
(3.9) [root@66992a12062f project]# df -h /                                                                                                                                                                           
Filesystem      Size  Used Avail Use% Mounted on                                                                                                                                                                     
/dev/sdb3       930G  683G  246G  74% /                                                                                                                                                                              
(3.9) [root@66992a12062f project]# pip install \                                                                                                                                                                     
>   --only-binary=":all:" \                                                                                                                                                                                          
>   --find-links=/project/dep-wheels \                                                                                                                                                                               
>   --find-links=/project/pyt-wheels \                                                                                                                                                                               
>   --no-index \                                                                                                                                                                                                     
>   --no-deps \                                                                                                                                                                                                      
>   pydeephaven pydeephaven-ticking                                                                                                                                                                                  
Looking in links: /project/dep-wheels, /project/pyt-wheels                                                                                                                                                           
Processing ./dep-wheels/pydeephaven-0.36.0+snapshot-py3-none-any.whl                                                                                                                                                 
Processing ./pyt-wheels/pydeephaven_ticking-0.36.0+snapshot-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.whl                                                                                                 
Installing collected packages: pydeephaven-ticking, pydeephaven                                                                                                                                                      
Successfully installed pydeephaven-0.36.0+snapshot pydeephaven-ticking-0.36.0+snapshot                                                                                                                               
(3.9) [root@66992a12062f project]# pip install \                                                                                                                                                                     
>   --only-binary=":all:" \                                                                                                                                                                                          
>   --find-links=/project/dep-wheels \                                                                                                                                                                               
>   --find-links=/project/pyt-wheels \                                                                                                                                                                               
>   pydeephaven pydeephaven-ticking                                                                                                                                                                                  
Looking in links: /project/dep-wheels, /project/pyt-wheels                                                                                                                                                           
Requirement already satisfied: pydeephaven in ./3.9/lib/python3.9/site-packages (0.36.0+snapshot)                                                                                                                    
Requirement already satisfied: pydeephaven-ticking in ./3.9/lib/python3.9/site-packages (0.36.0+snapshot)                                                                                                            
Collecting pyarrow (from pydeephaven)
  Downloading pyarrow-17.0.0-cp39-cp39-manylinux_2_28_x86_64.whl.metadata (3.3 kB)                                                                                                                                   
Collecting bitstring (from pydeephaven)
  Downloading bitstring-4.2.3-py3-none-any.whl.metadata (5.0 kB)
Collecting grpcio (from pydeephaven)
  Downloading grpcio-1.65.4-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.whl.metadata (3.3 kB)                                                                                                               
Collecting protobuf (from pydeephaven)
  Downloading protobuf-5.27.3-cp38-abi3-manylinux2014_x86_64.whl.metadata (592 bytes)                                                                                                                                
Collecting bitarray<3.0.0,>=2.9.0 (from bitstring->pydeephaven)
  Downloading bitarray-2.9.2-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.whl.metadata (34 kB)                                                                                                               
Collecting numpy>=1.16.6 (from pyarrow->pydeephaven)
  Downloading numpy-2.0.1-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.whl.metadata (60 kB)                                                                                                                  
Downloading bitstring-4.2.3-py3-none-any.whl (71 kB)
Downloading grpcio-1.65.4-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (5.7 MB)                                                                                                                          
   ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 5.7/5.7 MB 2.9 MB/s eta 0:00:00                                                                                                                                          
Downloading protobuf-5.27.3-cp38-abi3-manylinux2014_x86_64.whl (309 kB)
Downloading pyarrow-17.0.0-cp39-cp39-manylinux_2_28_x86_64.whl (39.9 MB)
   ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 39.9/39.9 MB 1.6 MB/s eta 0:00:00                                                                                                                                        
Downloading bitarray-2.9.2-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (286 kB)                                                                                                                         
Downloading numpy-2.0.1-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (19.5 MB)                                                                                                                           
   ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 19.5/19.5 MB 1.9 MB/s eta 0:00:00                                                                                                                                        
Installing collected packages: bitarray, protobuf, numpy, grpcio, bitstring, pyarrow                                                                                                                                 
Successfully installed bitarray-2.9.2 bitstring-4.2.3 grpcio-1.65.4 numpy-2.0.1 protobuf-5.27.3 pyarrow-17.0.0

@devinrsmith
Copy link
Member Author

The bigger culprit may be the image builder image:

$ docker images                                                                                                                                                                           
REPOSITORY                                                    TAG                            IMAGE ID       CREATED          SIZE                                                                                    
deephaven/test-c-python-client-ticking-3.9-ubi-minimal        local-build                    af68b8e823ac   44 minutes ago   395MB                                                                                   
deephaven/py-client-ticking-wheel-cp39-cp39                   local-build                    0bb83c4024f6   46 minutes ago   1.5GB   

@devinrsmith
Copy link
Member Author

It's possible that we've relied on >14GB of disk space, and just more recently, GH CI has reduced the amount of disk space:

https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories

actions/runner-images#9251

devinrsmith added a commit to devinrsmith/deephaven-core that referenced this issue Aug 5, 2024
This removes unneeded data from the CI runner to free up extra disk space using https://github.com/jlumbroso/free-disk-space. An emphasis has been placed on the speed of removal, and as such, a few of the defaults have been changed. Namely, docker image deletion and large misc packages have been explicitly set to false (as they are more complex than a simple `rm`). The tool cache deletion has also been set to false, as we might take advantage of that for java.

Fixes deephaven#5899
@devinrsmith devinrsmith linked a pull request Aug 5, 2024 that will close this issue
@devinrsmith
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci core Core development tasks devrel-watch DevRel team is watching
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants