Encapsulate the Manage Object to Hide Internal Details #107
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
NOTE: This depends on #86, #87, #88, #103 and is targeted to
go-sdk-v1
release. Will rebase when dependent PRs are merged. The diff in this PR will look pretty nasty until subsequent depend PRs are merged first. Until these get merged, here is a better looking diff to track the changes between branches: dvonthenen/deepgram-go-sdk@dv/prerecorded-object-definition...dvonthenen:deepgram-go-sdk:dv/manage-object-definitionAddresses #104, #105, #106.
Implements more of an object-oriented approach to handling the Manage struct. This change implements the following:
manage
functionsmanage
examples/balances
examples/invitations
examples/keys
examples/members
examples/prerecorded
(this was already there)examples/projects
examples/scopes
examples/streaming
(this was already there)examples/usage
Types of changes
What types of changes does your code introduce to the community Go SDK?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
PR #86 handled the restructure of the project. This is the first PR to start refactoring and improving individual components in this new restructure. This PR handles just the Live Client and Live Client only. I am trying to reduce the amount of code change in this PR and each component will be handled one at a time.
Will squash the commits after the review is completed.