Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the
docs
job in the CI : https://github.com/deepcharles/ruptures/actions/runs/3826472378/jobs/6510297491The underlying reason is that the API of sklearn's CountVectorizer has changed (see here for change).
get_feature_names
is now deprecated and becomesget_feature_names_out
.Edit
Actually
docs/examples/music-segmentation.ipynb
anddocs/examples/kernel-cpd-performance-comparison.ipynb
were not passing also. Had to run thenbqa-black
pre-commit locally.Moreover, I had to re-order imports in
docs/examples/music-segmentation.ipynb
because (I guess), something was shadowingmatplotlib.something
.