Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix example notebooks #287

Merged
merged 6 commits into from
Mar 28, 2023
Merged

Conversation

oboulant
Copy link
Collaborator

@oboulant oboulant commented Mar 28, 2023

This PR fixes the docs job in the CI : https://github.com/deepcharles/ruptures/actions/runs/3826472378/jobs/6510297491

The underlying reason is that the API of sklearn's CountVectorizer has changed (see here for change).

get_feature_names is now deprecated and becomes get_feature_names_out.

Edit

Actually docs/examples/music-segmentation.ipynb and docs/examples/kernel-cpd-performance-comparison.ipynb were not passing also. Had to run the nbqa-black pre-commit locally.

Moreover, I had to re-order imports in docs/examples/music-segmentation.ipynb because (I guess), something was shadowing matplotlib.something.

@github-actions github-actions bot added the Type: Documentation Documentation only changes label Mar 28, 2023
@oboulant oboulant changed the title docs: fix text segmentation notebook docs: fix example notebooks Mar 28, 2023
@oboulant oboulant self-assigned this Mar 28, 2023
@oboulant oboulant added the Type: Fix Bug or Bug fixes label Mar 28, 2023
@deepcharles
Copy link
Owner

Thanks!

@oboulant oboulant merged commit b8518be into master Mar 28, 2023
@oboulant oboulant deleted the docs/fix-text-segmentation-notebook branch March 28, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Documentation Documentation only changes Type: Fix Bug or Bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants