Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: make coverage computation work #220

Merged
merged 1 commit into from
Oct 21, 2021
Merged

ci: make coverage computation work #220

merged 1 commit into from
Oct 21, 2021

Conversation

oboulant
Copy link
Collaborator

@oboulant oboulant commented Oct 20, 2021

Coverage reports were not uploaded to codecov. The PR that stops generating coverage reports is :

We noticed it while switching to the new Codecov Uploader due to depreciation of the one we were using (see here for explanations). But, I introduced an error while using the pytest-cov command line options. Indeed, for some reasons, what used to work does not work anymore. Seems like there are some ambiguities while specifying the path the to source to be tested if we do it at the pytest/pytest-cov level (either pointing to the sources or to the package name).

Solution :

  • explicitly specify the package name (after installing it) as an option to coverage (found the doc here).
  • explicitly ask for coverage computation at command line call time (not in the config pyproject.toml)

@github-actions github-actions bot added the Type: CI Changes to CI configuration files and scripts label Oct 20, 2021
@codecov
Copy link

codecov bot commented Oct 20, 2021

Codecov Report

Merging #220 (5405f10) into master (d2d3097) will increase coverage by 96.71%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #220       +/-   ##
===========================================
+ Coverage    0.00%   96.71%   +96.71%     
===========================================
  Files          40       40               
  Lines         973      973               
===========================================
+ Hits            0      941      +941     
+ Misses        973       32      -941     
Flag Coverage Δ
unittests 96.71% <ø> (+96.71%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/ruptures/show/display.py 32.35% <0.00%> (+32.35%) ⬆️
src/ruptures/base.py 76.92% <0.00%> (+76.92%) ⬆️
src/ruptures/utils/utils.py 93.33% <0.00%> (+93.33%) ⬆️
src/ruptures/costs/costrank.py 93.33% <0.00%> (+93.33%) ⬆️
src/ruptures/__init__.py 100.00% <0.00%> (+100.00%) ⬆️
src/ruptures/exceptions.py 100.00% <0.00%> (+100.00%) ⬆️
src/ruptures/utils/bnode.py 100.00% <0.00%> (+100.00%) ⬆️
src/ruptures/costs/costl1.py 100.00% <0.00%> (+100.00%) ⬆️
src/ruptures/costs/costl2.py 100.00% <0.00%> (+100.00%) ⬆️
src/ruptures/costs/costml.py 100.00% <0.00%> (+100.00%) ⬆️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2d3097...5405f10. Read the comment docs.

@oboulant oboulant added the Type: Fix Bug or Bug fixes label Oct 20, 2021
@deepcharles deepcharles added Type: Maintenance Repository Maintenance and removed Type: Fix Bug or Bug fixes labels Oct 21, 2021
Copy link
Owner

@deepcharles deepcharles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oboulant oboulant merged commit a39f031 into master Oct 21, 2021
@oboulant oboulant deleted the ci/fix-test-coverage branch October 22, 2021 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: CI Changes to CI configuration files and scripts Type: Maintenance Repository Maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants