Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: add module imported but unused in flake8 #191

Merged
merged 4 commits into from
Jul 28, 2021

Conversation

oboulant
Copy link
Collaborator

Just add the F401 flake8 code to .flake8 so that we have a warning message when there is an unused import.
For instance in src/ruptures/utils/utils.py here with numpy.

@github-actions github-actions bot added the Type: Refactoring A code change that neither fixes a bug nor adds a feature label Jul 27, 2021
@oboulant oboulant marked this pull request as draft July 27, 2021 07:39
@codecov
Copy link

codecov bot commented Jul 27, 2021

Codecov Report

Merging #191 (f23a4c1) into master (d211c5c) will increase coverage by 0.27%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #191      +/-   ##
==========================================
+ Coverage   96.31%   96.59%   +0.27%     
==========================================
  Files          40       40              
  Lines         978      969       -9     
==========================================
- Hits          942      936       -6     
+ Misses         36       33       -3     
Impacted Files Coverage Δ
src/ruptures/datasets/pw_linear.py 100.00% <ø> (ø)
src/ruptures/utils/utils.py 93.33% <ø> (+12.38%) ⬆️
src/ruptures/detection/kernelcpd.py 100.00% <100.00%> (ø)
src/ruptures/metrics/hamming.py 100.00% <100.00%> (ø)
src/ruptures/metrics/precisionrecall.py 100.00% <100.00%> (ø)
src/ruptures/utils/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d211c5c...f23a4c1. Read the comment docs.

@oboulant oboulant marked this pull request as ready for review July 27, 2021 09:26
@deepcharles
Copy link
Owner

Good to me

@deepcharles deepcharles added Type: Maintenance Repository Maintenance and removed Type: Refactoring A code change that neither fixes a bug nor adds a feature labels Jul 27, 2021
@oboulant oboulant merged commit 605cfb9 into master Jul 28, 2021
@oboulant oboulant deleted the style-warning-unused-import branch July 28, 2021 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Repository Maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants