-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: do not triggers some gh actions for pre-commit-ci-update-config branch #186
Conversation
Codecov Report
@@ Coverage Diff @@
## master #186 +/- ##
=======================================
Coverage 96.31% 96.31%
=======================================
Files 40 40
Lines 978 978
=======================================
Hits 942 942
Misses 36 36 Continue to review full report at Codecov.
|
As can be seen in the commits, I tested several approaches :
This solution does not work because we do not have the guarantee that the PR is labelled before the jobs are started....
Might work but still, the jobs are started, it is just that the steps after the condition are ignored
If the PR only modifies |
Does it work now? I am a bit lost |
Yes it does. I try to explain everything I tried in this comment from the current PR. Bottom line, yes the PR is ready. And basically what it does is the following : for any newly created PR, if the PR consists only in a modification in By doing so, we can for instance avoid running tests for the automatically created PR from Let me know if unclear ! |
Oh ok cool. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect
The situation :
As of today, for the PRs automatically generated by
pre-commit-ci
from branchpre-commit-ci-update-config
tomaster
and only affecting.pre-commit-config.yaml
, run all the CI tests like any other PRs.What we do :
When only
.pre-commit-config.yaml
is affected by the PR, then the following Gh Actions are not run :