Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add aarch64 wheel build support #180

Merged
merged 1 commit into from
Jul 19, 2021

Conversation

odidev
Copy link
Contributor

@odidev odidev commented Jul 6, 2021

Added aarch64 wheel build support.
Related to #179, @julia-shenshina Could you please review this PR?

Signed-off-by: odidev <[email protected]>
steps:
- uses: actions/checkout@v1

- name: Set up QEMU
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does it do ? It helps with cross-compilation on aarch64 ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is used for setting up QEMU for enabling AArch64 binary execution on x86 machine.

@oboulant oboulant changed the title Add aarch64 wheel build support build: add aarch64 wheel build support Jul 8, 2021
@codecov
Copy link

codecov bot commented Jul 15, 2021

Codecov Report

Merging #180 (e4800e8) into master (c76dc78) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #180   +/-   ##
=======================================
  Coverage   96.31%   96.31%           
=======================================
  Files          40       40           
  Lines         978      978           
=======================================
  Hits          942      942           
  Misses         36       36           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c76dc78...e4800e8. Read the comment docs.

@deepcharles
Copy link
Owner

Looks good to me, even though I cannot test it before it is merged. Many thanks!

@oboulant
Copy link
Collaborator

Looks good to me, even though I cannot test it before it is merged. Many thanks!

If you manually run the Gh Actions on this specific branch and labelling it as a release candidate, it is not possible to test it ?

@deepcharles
Copy link
Owner

Looks good to me, even though I cannot test it before it is merged. Many thanks!

If you manually run the Gh Actions on this specific branch and labelling it as a release candidate, it is not possible to test it ?

I can only run the GH Action on a branch from this repo, but not on a branch from a fork.

@oboulant
Copy link
Collaborator

Looks good to me, even though I cannot test it before it is merged. Many thanks!

If you manually run the Gh Actions on this specific branch and labelling it as a release candidate, it is not possible to test it ?

I can only run the GH Action on a branch from this repo, but not on a branch from a fork.

In that case, maybe @odidev can modify the PR to be merge on a separate branch on ruptures repo. Then we can test, right ?

@odidev
Copy link
Contributor Author

odidev commented Jul 16, 2021

Following are the logs for wheel build and test. Please have a look and let me know if any changes are required in the PR:

  1. Wheel build: https://github.com/odidev/ruptures/actions/runs/1036426161

  2. Test logs: https://github.com/odidev/ruptures/actions/runs/1036426160

@oboulant
Copy link
Collaborator

Thanks for the links !
Looks good to me, thx !

@deepcharles
Copy link
Owner

deepcharles commented Jul 19, 2021

Looks good to me, many thanks.

@deepcharles deepcharles merged commit d211c5c into deepcharles:master Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants