-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: add aarch64 wheel build support #180
Conversation
Signed-off-by: odidev <[email protected]>
steps: | ||
- uses: actions/checkout@v1 | ||
|
||
- name: Set up QEMU |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does it do ? It helps with cross-compilation on aarch64 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is used for setting up QEMU for enabling AArch64 binary execution on x86 machine.
Codecov Report
@@ Coverage Diff @@
## master #180 +/- ##
=======================================
Coverage 96.31% 96.31%
=======================================
Files 40 40
Lines 978 978
=======================================
Hits 942 942
Misses 36 36 Continue to review full report at Codecov.
|
Looks good to me, even though I cannot test it before it is merged. Many thanks! |
If you manually run the Gh Actions on this specific branch and labelling it as a release candidate, it is not possible to test it ? |
I can only run the GH Action on a branch from this repo, but not on a branch from a fork. |
In that case, maybe @odidev can modify the PR to be merge on a separate branch on |
Following are the logs for wheel build and test. Please have a look and let me know if any changes are required in the PR: |
Thanks for the links ! |
Looks good to me, many thanks. |
Added aarch64 wheel build support.
Related to #179, @julia-shenshina Could you please review this PR?