Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(KernelCPD): explicitly cast signal into double #111

Merged
merged 1 commit into from
Jan 25, 2021

Conversation

oboulant
Copy link
Collaborator

Fix proposal for this issue

@github-actions github-actions bot added the Type: Fix Bug or Bug fixes label Jan 25, 2021
@codecov
Copy link

codecov bot commented Jan 25, 2021

Codecov Report

Merging #111 (8f9a7d9) into master (4049575) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #111   +/-   ##
=======================================
  Coverage   92.77%   92.78%           
=======================================
  Files          41       41           
  Lines         955      956    +1     
=======================================
+ Hits          886      887    +1     
  Misses         69       69           
Impacted Files Coverage Δ
src/ruptures/detection/kernelcpd.py 66.66% <100.00%> (+0.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4049575...8f9a7d9. Read the comment docs.

@oboulant oboulant linked an issue Jan 25, 2021 that may be closed by this pull request
@deepcharles
Copy link
Owner

LGTM!

@oboulant oboulant merged commit 874bc76 into master Jan 25, 2021
@oboulant oboulant deleted the fix-float-bitness branch January 25, 2021 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Fix Bug or Bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error if input data is not float64 for algos implemented in C
2 participants