-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: cleaner build process #107
Conversation
This file is generated by setuptools_scm
Result of `pre-commit autoupdate`
This controls the files that are included in sdist distributions.
Codecov Report
@@ Coverage Diff @@
## master #107 +/- ##
==========================================
+ Coverage 86.68% 92.77% +6.08%
==========================================
Files 41 41
Lines 954 955 +1
==========================================
+ Hits 827 886 +59
+ Misses 127 69 -58
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Very nice clean work ! 👏
* docs(costlinear): typo * test(costlinear): add test for CostLinear * docs: typo * test(costlinear): Make tests simplier and more integrated * test(costlinear): typo * test(costlinear): use simplier np.c_ Co-authored-by: Charles T <[email protected]>
* test(CostMl, CostCosine): Add test, delete duplicate functions, set random seed * refactor(pw_constant): inject seed for reproducible random state * test(test_costs): set random seed * test(test_costs): running black * test(costlinear): fix an import mishandled by merge with master
add an input field in the gh action to override the version number
This file is generated by setuptools_scm
Result of `pre-commit autoupdate`
This controls the files that are included in sdist distributions.
add an input field in the gh action to override the version number
Build all wheels and sdist THEN upload to pypi
…arles/ruptures into build/clean-build-process
replaced by the Github app results.pre-commit.ci
The GHA |
Several developper tools from this Scikit-HEP guide are introduced in this PR.
PEP 517/518
The
upload-to-pypi
Gh action was still using the legacypython setup.py sdist
command. It has been replaced by the newerpython -m build --sdist
.More information here.
MANIFEST.in
MANIFEST.in
controls the set of files that are included insdist
distributions. Before, many configurations files, and documentation were included. Now, onlysrc/
,tests/
and a few other files are included.More information here.
Versioning
The package version is now derived from the latest git tag, the latest commit and the date of build, thanks to the
setuptools_scm
package. The versioning scheme is decribed here. Now, we only need to add an appropriate tag (following semantic versioning) to bump the version.More information here.
Pre-commit hooks
Pre-commit hooks have been updated using
pre-commit autoupdate
.Documentation
The build and install procedures have updated in the various places of the documentation.