Merge pull request google#124 from deeglaze/minver

Allow an empty MinimumVersion
deeglaze · Mar 25, 2024 · 53e17a6 · 53e17a6
2 parents 0723fce + 2544dd9
commit 53e17a6
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/validate/validate.go b/validate/validate.go
@@ -193,9 +193,12 @@ func PolicyToOptions(policy *cpb.Policy) (*Options, error) {
 	if policy.GetMinimumBuild() > 255 {
 		return nil, fmt.Errorf("minimum_build is %d. Expect 0-255", policy.GetMinimumBuild())
 	}
-	minVersion, err := parseVersion(policy.GetMinimumVersion())
-	if err != nil {
-		return nil, fmt.Errorf("invalid minimum_version, %q: %v", policy.GetMinimumVersion(), err)
+	minVersion := uint16(0) // Allow an empty minimum version to mean "0.0"
+	if policy.GetMinimumVersion() != "" {
+		minVersion, err = parseVersion(policy.GetMinimumVersion())
+		if err != nil {
+			return nil, fmt.Errorf("invalid minimum_version, %q: %v", policy.GetMinimumVersion(), err)
+		}
 	}
 	for _, authorKeyHash := range policy.GetTrustedAuthorKeyHashes() {
 		if err := lengthCheck("trusted_author_key_hashes", abi.AuthorKeyDigestSize, authorKeyHash); err != nil {