Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sqlite transactions #1969

Merged
merged 1 commit into from
Jun 29, 2024
Merged

Conversation

arnauds5
Copy link
Collaborator

  • Add a missing defer tx.Rollback
  • Change some s.database.Exec(...) into tx.Exec(...) if it there is a transaction
  • Change unprocessed message sql query from "insert ..." to "insert or ignore ..." so that duplicate message doesn't block all the others messages to be handled

@arnauds5 arnauds5 requested a review from emonnin-epfl June 29, 2024 19:59
@arnauds5 arnauds5 requested a review from a team as a code owner June 29, 2024 19:59
Copy link

Pull reviewers stats

Stats of the last 30 days for popstellar:

User Total reviews Time to review Total comments
K1li4nL
🥇
23
▀▀▀▀
8h 33m
12
▀▀
matteosz
🥈
9
2d 1h 15m
22
▀▀▀
arnauds5
🥉
7
4h 29m
4
emonnin-epfl
6
8h 20m
8
sgueissa
4
1h 25m
7
onsriahi14
3
1d 10h 51m
4
quadcopterman
3
10d 7h 3m
▀▀▀▀
1
1florentin
2
10d 5h 50m
▀▀▀▀
0
MariemBaccari
2
22h 39m
6
Kaz-ookid
2
2d 4h 12m
9
simone-kalbermatter
1
9h 17m
0
⚡️ Pull request stats

Copy link

Copy link

Copy link

Copy link

Copy link
Contributor

@emonnin-epfl emonnin-epfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sgueissa sgueissa enabled auto-merge June 29, 2024 20:21
@sgueissa sgueissa added this pull request to the merge queue Jun 29, 2024
Merged via the queue into master with commit 58523c7 Jun 29, 2024
18 checks passed
@sgueissa sgueissa deleted the work-be1-arnauds5-fix-sqlite-transactions branch June 29, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants