-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix sqlite transactions #1969
fix sqlite transactions #1969
Conversation
arnauds5
commented
Jun 29, 2024
- Add a missing defer tx.Rollback
- Change some s.database.Exec(...) into tx.Exec(...) if it there is a transaction
- Change unprocessed message sql query from "insert ..." to "insert or ignore ..." so that duplicate message doesn't block all the others messages to be handled
Pull reviewers statsStats of the last 30 days for popstellar:
|
Quality Gate passed for 'PoP - PoPCHA-Web-Client'Issues Measures |
Quality Gate passed for 'PoP - Be2-Scala'Issues Measures |
Quality Gate passed for 'PoP - Be1-Go'Issues Measures |
Quality Gate passed for 'PoP - Fe2-Android'Issues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM