Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BE2] migrate to Scala 3 #1111

Closed
wants to merge 4 commits into from
Closed

[BE2] migrate to Scala 3 #1111

wants to merge 4 commits into from

Conversation

bbjubjub2494
Copy link
Collaborator

working on it

scapegoat is a compiler plugin so it isn't going to work trivially.

@bbjubjub2494 bbjubjub2494 requested a review from a team as a code owner June 13, 2022 09:51
@bbjubjub2494 bbjubjub2494 marked this pull request as draft June 13, 2022 10:00
@bbjubjub2494 bbjubjub2494 force-pushed the work-lourkeur-be2-scala3 branch from 2c7e7fa to 66603e5 Compare June 13, 2022 12:37
@bbjubjub2494
Copy link
Collaborator Author

Looks like we need to wait for the next Scala compiler release to get coverage info: scala/scala3#13880

@bbjubjub2494 bbjubjub2494 force-pushed the work-lourkeur-be2-scala3 branch from 66603e5 to a975922 Compare June 13, 2022 12:44
@bbjubjub2494 bbjubjub2494 mentioned this pull request Jun 13, 2022
Closed
@bbjubjub2494 bbjubjub2494 force-pushed the work-lourkeur-be2-scala3 branch 2 times, most recently from d1028f1 to ec6b1d5 Compare June 13, 2022 14:02
@bbjubjub2494 bbjubjub2494 self-assigned this Jun 13, 2022
@bbjubjub2494 bbjubjub2494 changed the base branch from master to work-lourkeur-be2-prepare-scala3 June 14, 2022 12:14
@bbjubjub2494 bbjubjub2494 force-pushed the work-lourkeur-be2-prepare-scala3 branch from 5711b1b to 09eafff Compare June 18, 2022 16:30
@bbjubjub2494 bbjubjub2494 force-pushed the work-lourkeur-be2-scala3 branch from ec6b1d5 to b1ef8e8 Compare June 18, 2022 16:30
@bbjubjub2494 bbjubjub2494 force-pushed the work-lourkeur-be2-prepare-scala3 branch from 09eafff to 71c7164 Compare June 23, 2022 15:38
@bbjubjub2494 bbjubjub2494 force-pushed the work-lourkeur-be2-scala3 branch from edeedd1 to 5afb61d Compare June 23, 2022 15:38
@bbjubjub2494 bbjubjub2494 force-pushed the work-lourkeur-be2-scala3 branch from 5afb61d to ea75e4f Compare June 30, 2022 20:17
@bbjubjub2494 bbjubjub2494 force-pushed the work-lourkeur-be2-prepare-scala3 branch 2 times, most recently from f02ed6f to 387a32e Compare June 30, 2022 20:30
@bbjubjub2494 bbjubjub2494 force-pushed the work-lourkeur-be2-scala3 branch 2 times, most recently from c96e837 to b4357b3 Compare July 6, 2022 13:24
@bbjubjub2494 bbjubjub2494 force-pushed the work-lourkeur-be2-prepare-scala3 branch from 387a32e to 95567f7 Compare July 6, 2022 13:25
@bbjubjub2494 bbjubjub2494 mentioned this pull request Jul 6, 2022
Merged
@bbjubjub2494 bbjubjub2494 force-pushed the work-lourkeur-be2-scala3 branch from b4357b3 to 0705162 Compare July 7, 2022 13:54
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 7, 2022

[PoP - Be1-Go] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 7, 2022

[PoP - Fe2-Android] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 7, 2022

[PoP - Fe1-Web] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@bbjubjub2494 bbjubjub2494 force-pushed the work-lourkeur-be2-scala3 branch from 0705162 to 2bcf4f4 Compare September 1, 2022 11:33
@bbjubjub2494 bbjubjub2494 force-pushed the work-lourkeur-be2-scala3 branch from 2bcf4f4 to 86dd3bc Compare September 1, 2022 11:54
@bbjubjub2494 bbjubjub2494 force-pushed the work-lourkeur-be2-prepare-scala3 branch from 95567f7 to 89b93b4 Compare September 1, 2022 11:56
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 1, 2022

[PoP - Be1-Go] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@bbjubjub2494
Copy link
Collaborator Author

Blocked by scala/scala3#15791

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 1, 2022

[PoP - Fe2-Android] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

67.3% 67.3% Coverage
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 1, 2022

[PoP - Fe1-Web] SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

49.8% 49.8% Coverage
1.1% 1.1% Duplication

@K1li4nL
Copy link
Contributor

K1li4nL commented Feb 25, 2024

done in #1742

@K1li4nL K1li4nL closed this Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rombirli rombirli rombirli left review comments

Assignees

@bbjubjub2494 bbjubjub2494

Labels
be2-scala
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bbjubjub2494 @K1li4nL @rombirli