Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

From c4dt #287

Merged
merged 17 commits into from
May 27, 2024
Merged

From c4dt #287

merged 17 commits into from
May 27, 2024

Conversation

jbsv
Copy link
Contributor

@jbsv jbsv commented May 27, 2024 •
edited
Loading 

  • add fastsync protocol which only sends new blocks when needed

  • various small fixes:

  •     timeouts (for mixing 10'000 ballots)

  •     clean up socket file so CLI can be started twice in a row

  • fix comparisons/updates of block indices and transaction nonces

see pull request #285

ineiti and others added 16 commits April 22, 2024 14:22
@ineiti
Adding RandomFilter
143a696 
Use RandomFilter to select a given amount of indexes randomly.

Added suggestion from @PascalinDe
@ineiti
Protocol definitions for fastsync
bca499a
@ineiti
Adding the fastsync protocol
06b1b5c
@ineiti
Making fastsync the default protocol
de866cb 
Adds the fastsync as default protocol to cosipbft.
Adds a 'WithBlockSync' option for the old, slow protocol.
Updates all the tests.
@ineiti
Using main for github workflow
252cde8
@ineiti
Updating the timeouts to make pass 1000 votes
d96665a 
- increased the default timeouts (tests set their own timeout)
- increased maximum message size over grpc
@ineiti
1h rounds...
2087655
@ineiti
Comments and repetitions
3f0bb98
@ineiti
Remove existing socket file upon startup
3c1f396
@ineiti
Increase logging
8d2944f
@ineiti
Put fast block sync into a unique place
c153b69
@ineiti
Fix comparisons and updates of block indexes and nonces
556fbdd
@ineiti
Doing some magic timeout adjustments
21f54f0
@ineiti
Fix tests
fa266d7
@ineiti
Don't use the sync beforehand - the manager.Make takes care of that
c1fc3e1
@jbsv
Merge pull request #286 from c4dt/for_dedis
4f9f8e1 
For dedis
@coveralls
Copy link

coveralls commented May 27, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9255516871

Details

  • 379 of 448 (84.6%) changed or added relevant lines in 16 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.4%) to 98.069%
Changes Missing Coverage Covered Lines Changed/Added Lines %
core/ordering/cosipbft/cosipbft.go 31 32 96.88%
dkg/pedersen/dkg.go 1 2 50.0%
core/ordering/cosipbft/blockstore/disk.go 1 3 33.33%
core/txn/signed/signed.go 3 7 42.86%
cli/node/daemon.go 2 7 28.57%
core/ordering/cosipbft/fastsync/json/json.go 53 59 89.83%
core/ordering/cosipbft/proc.go 53 62 85.48%
mino/option.go 9 18 50.0%
core/ordering/cosipbft/fastsync/default.go 156 188 82.98%
Files with Coverage Reduction New Missed Lines %
mino/minogrpc/server.go 2 96.64%
core/ordering/pow/pow.go 3 96.0%
Totals Coverage Status
Change from base Build 9098803224: -0.4%
Covered Lines: 15036
Relevant Lines: 15332
💛 - Coveralls

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 27, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
85.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@jbsv jbsv merged commit 7288f63 into main May 27, 2024
7 checks passed
@jbsv jbsv deleted the from-c4dt branch May 27, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jbsv @coveralls @ineiti