Add the TSM identity to Darc #2485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Trusted Secure Module is used by DuoKey to sign messages using a threshold signature scheme. This PR adds support for Darcs to verify those messages. It is used for the Master Thesis protject of Pilar Marxer.
tharvik
approved these changes
Feb 11, 2022
cgrigis
approved these changes
Feb 11, 2022
| return true | ||
| } | ||
| return false | ||
| return id.Type() != 0 |
There was a problem hiding this comment.
Does this mean identities other than Darc are always Primary?
There was a problem hiding this comment.
Yes - this is used to know which identities have counters. It should probably be renamed, but here I just thought it's useless to have this long switch/case, when a simple test would do...
| @@ -1120,6 +1187,8 @@ func ParseIdentity(in string) (Identity, error) { | |||
| return parseIDProxy(fields[1]) | |||
| case "evm_contract": | |||
| return parseIDEvmContract(fields[1]) | |||
| case "tsm": | |||
| return parseIDTSM(fields[1]) | |||
| default: | |||
There was a problem hiding this comment.
We have an issue now: #2486
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Trusted Secure Module is used by DuoKey to sign messages using a threshold signature
scheme. This PR adds support for Darcs to verify those messages. It is used for the
Master Thesis protject of Pilar Marxer.