Fix saved objects client _processBatchQueue function to handle errors (…

…elastic#26763) (elastic#26808) * Fix saved objects client _processBatchQueue function to handle errors * Fix error thrown in try/catch
dedemorton · Dec 7, 2018 · 7f9cde7 · 7f9cde7
1 parent 4042475
commit 7f9cde7
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 0 deletions.
diff --git a/src/ui/public/saved_objects/__tests__/saved_objects_client.test.js b/src/ui/public/saved_objects/__tests__/saved_objects_client.test.js
@@ -128,6 +128,21 @@ describe('SavedObjectsClient', () => {
       await savedObjectsClient.get(doc.type, doc.id);
       sinon.assert.calledOnce(kfetchStub);
     });
+
+    test('handles HTTP call when it fails', async () => {
+      kfetchStub.withArgs({
+        method: 'POST',
+        pathname: `/api/saved_objects/_bulk_get`,
+        query: undefined,
+        body: sinon.match.any
+      }).rejects(new Error('Request failed'));
+      try {
+        await savedObjectsClient.get(doc.type, doc.id);
+        throw new Error('should have error');
+      } catch (e) {
+        expect(e.message).to.be('Request failed');
+      }
+    });
   });
 
   describe('#delete', () => {

diff --git a/src/ui/public/saved_objects/saved_objects_client.js b/src/ui/public/saved_objects/saved_objects_client.js
@@ -215,6 +215,10 @@ export class SavedObjectsClient {
 
         queueItem.resolve(foundObject);
       });
+    }).catch((err) => {
+      queue.forEach((queueItem) => {
+        queueItem.reject(err);
+      });
     });
 
   }, BATCH_INTERVAL, { leading: false });