Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hall of fame #43

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Hall of fame #43

wants to merge 5 commits into from

Conversation

cnasikas
Copy link
Member

@cnasikas cnasikas commented Mar 22, 2019

Screenshot 2019-03-22 at 14 54 58

@dionyziz
Copy link
Member

Should we allow students to opt-out of hall of fame or anonymize their username? They may not want to appear due to privacy reasons.

@cnasikas
Copy link
Member Author

cnasikas commented Mar 22, 2019

Too much work for such a feature. Better to not include the Hall of Fame at all. It isn't a necessity.

EDIT: I agree about privacy concerns as the usernames are linked to github.

@dionyziz
Copy link
Member

dionyziz commented Mar 22, 2019 via email

@cnasikas
Copy link
Member Author

cnasikas commented Mar 22, 2019

No, not at all. See my edit. You are right that we shouldn't publish usernames at all. I propose to not merge these feature and delete it.

@dionyziz
Copy link
Member

dionyziz commented Mar 22, 2019 via email

@cnasikas
Copy link
Member Author

Ok. What about anonymize the usernames ? If we had our authentication this wouldn't be an issue right ?

@dionyziz
Copy link
Member

dionyziz commented Mar 22, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants