Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

main: Use latest dcrd deps. #389

Merged
merged 1 commit into from
Jun 11, 2023
Merged

main: Use latest dcrd deps. #389

merged 1 commit into from
Jun 11, 2023

Conversation

jholdstock
Copy link
Member

No description provided.

@jholdstock jholdstock marked this pull request as ready for review June 11, 2023 09:30
davecgh
davecgh reviewed Jun 11, 2023
View reviewed changes
go.mod
@@ -27,23 +27,17 @@ require (
go.etcd.io/bbolt v1.3.7
)

replace (
Copy link
Member

@davecgh davecgh Jun 11, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just an FYI. In the future if you want to consume development modules from another repository, like in this case, instead of using replaces, you should specifically require the minimum necessary in-development commits each one needs. That way it doesn't break consumers of your own module.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For example instead of requiring github.com/decred/dcrd/blockchain/stake/v5 v5.0.0 and then replacing github.com/decred/dcrd/blockchain/stake/v5 with github.com/decred/dcrd/blockchain/stake/v5 v5.0.0-20221022042529-0a0cc3b3bf92, instead just require github.com/decred/dcrd/blockchain/stake/v5 v5.0.0-20221022042529-0a0cc3b3bf92 directly.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the tip! Very helpful, it actually explains a couple of issues I've seen recently.

@jholdstock jholdstock merged commit 7cb4681 into decred:master Jun 11, 2023
@jholdstock jholdstock deleted the dcrd1.8 branch September 20, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davecgh davecgh davecgh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jholdstock @davecgh