ui: Add ability to change vote choice #25
Conversation
When connecting to dcrdata, pull down the current agendas for use when voting.
Add a screen to show current agendas and a dropdown menu to choose how to vote.
ui/screens.py
Outdated
|
|
||
| self.pages = [] | ||
| self.page = 0 | ||
| self.ignoreVoteIndexChange = False |
There was a problem hiding this comment.
Can you comment on the need for synchronization here? See my comment below, but If you use the full waiting screen provided by app.waitThread, this wouldn't be needed either.
There was a problem hiding this comment.
do you mean to set the vote?
There was a problem hiding this comment.
This property appears to be used to prevent concurrent calls to onChooseChoice. Am I reading that right?
This is okay, though I question the utility. Were you seeing some undesirable behavior without it?
There was a problem hiding this comment.
There is an onconnected() function listening to changes in the dropdowns/comboboxes. It is triggered when a user clicks a new choice, which is good. It also triggers when we initially set the vote, which is not optimal.
For instance we make the dropdown and default index is zero. After checking with the user's pool their choice is "yes" at index 1, so we change it. Because we change it the onconnected () fires and sends an unnecessary request to the pool to set the vote to yes, although it is already yes.
Another way to avoid this is to ignore changes until we are synced, but I made this with the idea that a user can have different vote choices for different pools. So the problem happens again upon switching pools. I could change it so that the user has one one choice per wallet, and then we just set everything to that choice and set all new, old pools to the same vote choice, then I don't think this variable would be necessary.
Unless you have a better way?
There was a problem hiding this comment.
Instead of currentIndexChanged, connect to the activated signal. The only caveat is that you'll have to verify something has actually changed before proceeding, because activated will be triggered even if they select the same thing that was already selected.
There was a problem hiding this comment.
Ok, I'll do it that way. Thanks!
There was a problem hiding this comment.
ok. I think this is optimized, but let me know.
|
I'm still not quite sure about the |
|
still not completely sure that this is what you want as far as syncing. You are locked out of the voting screen unless certain conditions are met. s'ok? |
Save a reference to the drowdown in the function that fires when activated. Move agendasInfo back to dcrdata blockchain.
ui/screens.py
Outdated
| # Refresh purchase info | ||
| pools[0].getPurchaseInfo() |
There was a problem hiding this comment.
Need at least of a try/except here. Also just realized that this is being called every time the PoolAccountScreen is stacked, which seems excessive. We'll need to maybe implement an expiration time on this information.
Also realized that we don't have a good testnet VSP to test against right now. I'm getting an expired certificate error for teststakepool.decred.org, and all of the others have issues too. Solution needed.
There was a problem hiding this comment.
https://www.dcrstakedinner.com
How long do you think the expiration should be? Because the user could change this via the vsp's web interface, I think too long is not good. Maybe an hour?
Add a screen to show current agendas and a dropdown menu to choose how
to vote.
screens