Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Use core toolkit on politeia app-shell #2881

Merged
merged 31 commits into from
Jan 12, 2023
Merged

refactor: Use core toolkit on politeia app-shell #2881

merged 31 commits into from
Jan 12, 2023

Conversation

victorgcramos
Copy link
Member

@victorgcramos victorgcramos commented Dec 6, 2022 •
edited
Loading

This PR adds the politeiagui toolkit (#2869) on politeia app-shell,
which includes:

  • Use createSliceServices tool on plugins to create their servicesListeners and
    pluginsServices
  • Install created services on exported plugins configs
  • Setup services properly on politeia app-shell according to the toolkit format
  • Code cleanup and organize routes services on a readable way

@victorgcramos victorgcramos marked this pull request as draft December 6, 2022 14:48
@victorgcramos
chore(pi): export pi services
6006c03
@victorgcramos
chore(comments): export comments services
fab6d2c
@victorgcramos
chore(pi): use toolkit services on pi plugin
bea2b82
@victorgcramos
chore: add exports on jsconfig
39351f5
@victorgcramos
refactor(core): toolkit default inject effect args
9ae6d28
@victorgcramos
refactor(app/pi): use toolkit on proposals lists
d8a512f
@victorgcramos
refactor(pi): rewrite proposals slice reducers
b15b005
@victorgcramos
refactor(pi): isolate status changes listeners
8e2281c
@victorgcramos
chore(comments): rename counts fetch all service
7c7b95a
@victorgcramos
refactor(app/pi): user toolkit on Details page
b81ed2d
@victorgcramos
style(ticketvote): old services cleanup
536ce16
@victorgcramos
style(core): records old services cleanup
f4296ec
@victorgcramos
style(comments): old services cleanup
028c77f
@victorgcramos
style(pi): old services cleanup
badc1b1
@victorgcramos
refactor(core): use toolkit on global services
5d78f60
@victorgcramos
fix(app/pi): update downloads services setups
d491f47
@victorgcramos
test(app/pi): minor downloads e2e tests fixes
4361a0f
@victorgcramos
chore: sync master
3871978
@victorgcramos
fix(core): remove circular deps on global services
211e4ea
@victorgcramos victorgcramos marked this pull request as ready for review December 8, 2022 20:17
tiagoalvesdulce
tiagoalvesdulce approved these changes Jan 12, 2023
View reviewed changes
Copy link
Member

@tiagoalvesdulce tiagoalvesdulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiagoalvesdulce tiagoalvesdulce merged commit c21f123 into decred:master Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiagoalvesdulce tiagoalvesdulce tiagoalvesdulce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@victorgcramos @tiagoalvesdulce