refactor: Replace hard code page size.

src/components/Proposal/RawProposal.jsx

@@ -3,11 +3,18 @@ import get from "lodash/fp/get";
 import { classNames } from "pi-ui";
 import { getMarkdownContent } from "src/containers/Proposal/helpers";
 import { useProposal } from "src/containers/Proposal/Detail/hooks";
+import usePolicy from "src/hooks/api/usePolicy";
 import styles from "./Proposal.module.css";
 
 const RawProposal = ({ match }) => {
+  const {
+    policyTicketVote: { summariespagesize: proposalPageSize }
+  } = usePolicy();
   const tokenFromUrl = get("params.token", match);
-  const { proposal, loading, error } = useProposal(tokenFromUrl);
+  const { proposal, loading, error } = useProposal(
+    tokenFromUrl,
+    proposalPageSize
+  );
   const rawMarkdown = proposal ? getMarkdownContent(proposal.files) : null;
   return !loading && !error ? (
     <div>

src/containers/Proposal/Admin/Admin.jsx

@@ -7,6 +7,9 @@ import useProposalsStatusChangeUser from "src/hooks/api/useProposalsStatusChange
 import { PROPOSAL_STATUS_CENSORED } from "src/constants";
 import { tabValues, statusByTab } from "./helpers";
 import { mapProposalsTokensByTab } from "src/containers/Proposal/helpers";
+import usePolicy from "src/hooks/api/usePolicy";
+// XXX change to AdminActionsProvider
+
 import {
   UnvettedActionsProvider,
   PublicActionsProvider
@@ -26,6 +29,12 @@ const AdminProposals = ({ TopBanner, PageDetails, Main }) => {
     0,
     tabLabels
   );
+  const {
+    policyTicketVote: {
+      summariespagesize: proposalPageSize,
+      inventorypagesize: inventoryPageSize
+    }
+  } = usePolicy();
   const {
     proposals: batchProposals,
     proposalsTokens,
@@ -39,7 +48,9 @@ const AdminProposals = ({ TopBanner, PageDetails, Main }) => {
     fetchVoteSummary: false,
     fetchProposalSummary: true,
     unvetted: true,
-    proposalStatus: statusByTab[tabLabels[tabIndex]]
+    proposalStatus: statusByTab[tabLabels[tabIndex]],
+    proposalPageSize: proposalPageSize,
+    inventoryPageSize: inventoryPageSize
   });
 
   const { proposals, loading: mdLoading } = useProposalsStatusChangeUser(
@@ -78,6 +89,7 @@ const AdminProposals = ({ TopBanner, PageDetails, Main }) => {
       dropdownTabsForMobile={true}
       hasMore={hasMoreProposals}
       isLoading={loading || verifying || mdLoading}
+      pageSize={proposalPageSize}
       getEmptyMessage={getEmptyMessage}>
       {({ tabs, content }) => (
         <>

src/containers/Proposal/Detail/Detail.jsx

@@ -40,6 +40,7 @@ import { shortRecordToken } from "src/helpers";
 import ModalLogin from "src/components/ModalLogin";
 import useModalContext from "src/hooks/utils/useModalContext";
 import { usePaywall, useIdentity } from "src/hooks";
+import usePolicy from "src/hooks/api/usePolicy";
 
 const COMMENTS_LOGIN_MODAL_ID = "commentsLoginModal";
 
@@ -51,6 +52,9 @@ const SetPageTitle = ({ title }) => {
 const ProposalDetail = ({ Main, match, history }) => {
   const tokenFromUrl = shortRecordToken(get("params.token", match));
   const threadParentCommentID = get("params.commentid", match);
+  const {
+    policyTicketVote: { summariespagesize: proposalPageSize }
+  } = usePolicy();
   const {
     proposal: fetchedProposal,
     loading,
@@ -65,7 +69,7 @@ const ProposalDetail = ({ Main, match, history }) => {
     commentsError,
     commentsLoading,
     onReloadProposalDetails
-  } = useProposal(tokenFromUrl, threadParentCommentID);
+  } = useProposal(tokenFromUrl, proposalPageSize, threadParentCommentID);
   const { userid } = currentUser || {};
   const isSingleThread = !!threadParentID;
   const { proposals, loading: mdLoading } = useProposalsStatusChangeUser(

src/containers/Proposal/Detail/hooks.js

@@ -45,7 +45,7 @@ const getProposalRfpLinksTokens = (proposal) => {
   return isSubmission ? [proposal.linkto] : proposal.linkedfrom;
 };
 
-export function useProposal(token, threadParentID) {
+export function useProposal(token, proposalPageSize, threadParentID) {
   const tokenShort = shortRecordToken(token);
   const onFetchProposalDetails = useAction(act.onFetchProposalDetails);
   const onFetchProposalsBatch = useAction(act.onFetchProposalsBatch);
@@ -148,8 +148,10 @@ export function useProposal(token, threadParentID) {
       },
       verify: () => {
         if (hasRemainingTokens) {
-          const [tokensBatch, next] =
-            getTokensForProposalsPagination(remainingTokens);
+          const [tokensBatch, next] = getTokensForProposalsPagination(
+            remainingTokens,
+            proposalPageSize
+          );
           // Fetch vote & proposal summaries only if the proposal is a RFP.
           // If it is a submission, just grab the records info.
           onFetchProposalsBatch({

src/containers/Proposal/Edit/Edit.jsx

@@ -20,10 +20,14 @@ import { getMarkdownContent, isPublicProposal } from "../helpers";
 import { formatUnixTimestampToObj } from "src/utils";
 import { getAttachmentsFiles } from "src/helpers";
 import { usdFormatter } from "src/utils";
+import usePolicy from "src/hooks/api/usePolicy";
 
 const EditProposal = ({ match }) => {
   const tokenFromUrl = get("params.token", match);
-  const { proposal, loading } = useProposal(tokenFromUrl);
+  const {
+    policyTicketVote: { summariespagesize: proposalPageSize }
+  } = usePolicy();
+  const { proposal, loading } = useProposal(tokenFromUrl, proposalPageSize);
   const isPublic = isPublicProposal(proposal);
   const { onEditProposal, currentUser } = useEditProposal();
   const { userid } = currentUser || {};

src/containers/Proposal/User/Submitted.jsx

@@ -9,6 +9,7 @@ import {
 import LazyList from "src/components/LazyList";
 import LoadingPlaceholders from "src/components/LoadingPlaceholders";
 import HelpMessage from "src/components/HelpMessage";
+import usePolicy from "src/hooks/api/usePolicy";
 
 const PAGE_SIZE = 20;
 
@@ -20,8 +21,11 @@ const Proposals = (props) => {
   const [hasMoreToLoad, setHasMore] = useState(false);
 
   const { userID } = props;
+  const {
+    policyTicketVote: { summariespagesize: proposalPageSize }
+  } = usePolicy();
   const { proposals, loading, numOfUserProposals, onFetchMoreProposals } =
-    useUserProposals({ userID });
+    useUserProposals({ proposalPageSize, userID });
 
   const amountOfProposalsFetched = proposals ? proposals.length : 0;
 

src/containers/Proposal/Vetted/Vetted.jsx

@@ -1,4 +1,5 @@
 import React, { useCallback, useMemo } from "react";
+import get from "lodash/fp/get";
 import isEmpty from "lodash/fp/isEmpty";
 import styles from "./VettedProposals.module.css";
 import { tabValues, statusByTab, sortByTab } from "./helpers";
@@ -13,6 +14,7 @@ import { LIST_HEADER_VETTED, INELIGIBLE } from "src/constants";
 import useQueryStringWithIndexValue from "src/hooks/utils/useQueryStringWithIndexValue";
 import { PROPOSAL_STATUS_CENSORED } from "src/constants";
 import useProposalsStatusChangeUser from "src/hooks/api/useProposalsStatusChangeUser";
+import usePolicy from "src/hooks/api/usePolicy";
 
 const renderProposal = (record) => (
   <Proposal key={record.censorshiprecord.token} proposal={record} />
@@ -29,6 +31,16 @@ const VettedProposals = ({ TopBanner, PageDetails, Sidebar, Main }) => {
   const [index, onSetIndex] = useQueryStringWithIndexValue("tab", 0, tabLabels);
   const statuses = statusByTab[tabLabels[index]];
   const sort = sortByTab[tabLabels[index]];
+  const policy = usePolicy();
+  const proposalPageSize = get(policy, [
+    "policyTicketVote",
+    "summariespagesize"
+  ]);
+  const inventoryPageSize = get(policy, [
+    "policyTicketVote",
+    "inventorypagesize"
+  ]);
+
   const {
     proposals: batchProposals,
     proposalsTokens,
@@ -40,9 +52,12 @@ const VettedProposals = ({ TopBanner, PageDetails, Sidebar, Main }) => {
     isProposalsBatchComplete
   } = useProposalsBatch({
     fetchRfpLinks: true,
+    fetchVoteSummaries: true,
+    statuses: statuses,
+    proposalPageSize: proposalPageSize,
+    inventoryPageSize: inventoryPageSize,
     fetchVoteSummary: true,
-    fetchProposalSummary: true,
-    statuses: statuses
+    fetchProposalSummary: true
   });
 
   const { proposals, loading: mdLoading } = useProposalsStatusChangeUser(
@@ -130,6 +145,7 @@ const VettedProposals = ({ TopBanner, PageDetails, Sidebar, Main }) => {
       dropdownTabsForMobile
       hasMore={hasMoreProposals}
       isLoading={loading || verifying || mdLoading}
+      pageSize={proposalPageSize}
       sort={sort}>
       {content}
     </RecordsView>

src/hooks/api/useProposalsBatch.js

@@ -57,10 +57,6 @@ const getUnfetchedTokens = (proposals, tokens) =>
     keys(proposals).map((token) => shortRecordToken(token))
   );
 
-const getCurrentPage = (tokens) => {
-  return tokens ? Math.floor(+tokens.length / INVENTORY_PAGE_SIZE) : 0;
-};
-
 const cacheVoteStatus = {};
 
 const updateCacheVoteStatusMap = (voteSummaries, isRefresh) => {
@@ -93,7 +89,8 @@ export default function useProposalsBatch({
   unvetted = false,
   proposalStatus,
   statuses,
-  proposalPageSize = PROPOSAL_PAGE_SIZE
+  proposalPageSize = PROPOSAL_PAGE_SIZE,
+  inventoryPageSize = INVENTORY_PAGE_SIZE
 }) {
   const [remainingTokens, setRemainingTokens] = useState([]);
   const [voteStatuses, setStatuses] = useState(statuses);
@@ -125,8 +122,8 @@ export default function useProposalsBatch({
     [allByStatus, isByRecordStatus, currentStatus]
   );
   const page = useMemo(() => {
-    return getCurrentPage(tokens);
-  }, [tokens]);
+    return tokens ? Math.floor(+tokens.length / inventoryPageSize) : 0;
+  }, [tokens, inventoryPageSize]);
   const errorSelector = useMemo(
     () => or(sel.apiProposalsBatchError, sel.apiPropsVoteSummaryError),
     []
@@ -165,7 +162,7 @@ export default function useProposalsBatch({
         // there are no tokens to be fetched from the next page
         const scanNextStatus =
           initializedInventory &&
-          (!(tokens.length % INVENTORY_PAGE_SIZE === 0 && tokens.length > 0) ||
+          (!(tokens.length % inventoryPageSize === 0 && tokens.length > 0) ||
             remainingTokens.length === proposalPageSize);
         if (scanNextStatus) {
           const { index, tokens } = scanNextStatusTokens(
@@ -332,7 +329,7 @@ export default function useProposalsBatch({
     !getUnfetchedTokens(proposals, tokens).length;
 
   const isAnotherTokensScanningRequired =
-    tokens && tokens.length && tokens.length % INVENTORY_PAGE_SIZE === 0;
+    tokens && tokens.length && tokens.length % inventoryPageSize === 0;
 
   const onFetchMoreProposals = useCallback(() => {
     if (remainingTokens.length < proposalPageSize) return send(START);