feat: add rules to new proposal page #2290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorgcramos
approved these changes
Jan 14, 2021
Comment on lines
227
to
252
| <H3>Rules:</H3> | ||
| <ul className="margin-top-s margin-bottom-m"> | ||
| <ListItem> | ||
| Expenses must be denominated in USD (but will be paid in DCR) | ||
| </ListItem> | ||
| <ListItem> | ||
| The work will be paid next month after the month it was done, as | ||
| explained{" "} | ||
| <Link | ||
| href="https://docs.decred.org/contributing/contributor-compensation/" | ||
| target="_blank" | ||
| rel="noopener noreferrer"> | ||
| here | ||
| </Link> | ||
| </ListItem> | ||
| <ListItem>Proposal must include actionable plan</ListItem> | ||
| <ListItem> | ||
| Check{" "} | ||
| <Link | ||
| href="https://docs.decred.org/governance/politeia/proposal-guidelines/" | ||
| target="_blank" | ||
| rel="noopener noreferrer"> | ||
| Proposal Guidelines | ||
| </Link> | ||
| </ListItem> | ||
| </ul> |
There was a problem hiding this comment.
what about moving it to a separate component, like you did with ListItem? I think this would improve the code readability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2116
UI Changes Screenshot
Mobile
Desktop