Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[redesign] Add censor comment action for admins #1360

Merged
merged 4 commits into from
Sep 4, 2019

Conversation

thi4go
Copy link
Member

@thi4go thi4go commented Aug 30, 2019

closes #1343

Copy link
Member

@fernandoabolafio fernandoabolafio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thi4go overall it looks good to me, I just left an inline comment for you.

@MariaPleshkova can we move the "censor" button to the bottom of the comment? This button won't have space on mobile views, because of the up/downvotes.
Screen Shot 2019-08-30 at 17 17 37

src/containers/Comments/Comment/CommentWrapper.jsx Outdated Show resolved Hide resolved
@fernandoabolafio
Copy link
Member

@thi4go one more thing, the "Censor" button should not appear if the comment is already censored.

@fernandoabolafio fernandoabolafio changed the title Add censor comment action for admins [redesign] Add censor comment action for admins Aug 30, 2019
@thi4go
Copy link
Member Author

thi4go commented Sep 3, 2019

Addressed the review comments @fernandoabolafio 👍

Copy link
Member

@fernandoabolafio fernandoabolafio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@fernandoabolafio fernandoabolafio merged commit 495b5de into decred:master Sep 4, 2019
@MariaPleshkova
Copy link

@fernandoabolafio I suggest to do it this way on mobile
image
It's better not to put Censor button close to Reply

@fernandoabolafio
Copy link
Member

ok @MariaPleshkova. I will create an issue for that since this is merged already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[redesign] Censor of comments
3 participants