Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cms] Add line item payout summary commands #921

Merged
merged 3 commits into from
Jun 14, 2019

Conversation

alexlyp
Copy link
Member

@alexlyp alexlyp commented Jun 13, 2019

This command allows administrators to query the cms database for
all paid out line items within a given period of time. This will be
used to create public summaries of expenditures by domain for any
given month.

This command allows administrators to query the cms database for
all paid out line items within a given period of time.  This will be
used to provide public summaries of expenditures for any given month.
Copy link
Member

@lukebp lukebp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. My only comment is that you're killing me with the 80 column limit. We treat it as a hard limit in the politeia repo. You really need to add a visual cue to your editor to mark column 80 so that I don't have to keep leaving the same comment.

@alexlyp
Copy link
Member Author

alexlyp commented Jun 14, 2019

OK looked for any possible 80 char over limit. Understood. While I do have a 80 char limit marker set up, I didn't realize that it was such a hard rule. Will be more aware moving forward.

Copy link
Member

@lukebp lukebp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much appreciated!

@alexlyp alexlyp merged commit 3fba5a1 into decred:master Jun 14, 2019
@alexlyp alexlyp deleted the ayp_payout_summary branch June 14, 2019 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants