logger: Fix nil pointer bug. #1540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a nil pointer bug that was hit when a package attempts to use its logger without having the log rotator setup. Now that individual packages initialize the logger themselves instead of having it initialized in main, it's possible for package loggers to be used without ever having the log rotator setup. An example is when CLI tools use politeiawww packages like when dbutil uses the userdb implemenations.
|
This bug was introduced by #1527. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a nil pointer bug that is hit when a package attempts to
use its logger without having the log rotator setup.
Now that individual packages initialize the logger themselves instead of
having it initialized by main, it's possible for package loggers to be
used without ever having the log rotator setup. An example is when CLI
tools use politeiawww packages, like when dbutil uses the userdb
implemenations.