politeiawww: Refactor config for rewrite. #1536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This refactors the politeiawww config to prep it for the user layer rewrite. It makes the following changes: - Moves all code for parsing and verifying the config settings into the `config` package. - Separates out the config settings that are for legacy API into a `LegacyConfig` struct. The `LegacyConfig` struct is embedded onto the standard `Config` struct so that it remains compatible with the legacy code while still differentiating between deprecated and non-depreacted settings. The `LegacyConfig` will be deleted in the future. - Refactors all config parsing and validation code in order to clean it up.
lukebp
changed the title
marcopeereboom
approved these changes
Oct 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the politeiawww config to prep it for the user layer
rewrite. It makes the following changes:
Moves all code for parsing and verifying the config settings into the
configpackage.Separates out the config settings that are for legacy API into a
LegacyConfigstruct. TheLegacyConfigstruct is embedded onto thestandard
Configstruct so that it remains compatible with the legacycode while still differentiating between deprecated and non-depreacted
settings. The
LegacyConfigwill be deleted in the future.Refactors all config parsing and validation code in order to clean it
up.