ticketvote: Add cache fsck #1531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lukebp ready for a review mate 👍 |
lukebp
requested changes
Oct 8, 2021
|
Hey @lukebp appreciate it mate. You've been an excellent team lead, so I also have you to thank for. This is ready for another look 👍 |
|
Actually still fixing one thing @lukebp will push in a bit |
|
Good to go now @lukebp |
lukebp
requested changes
Oct 11, 2021
There was a problem hiding this comment.
It doesn't look like you've tested this against all record status.
Populate your backend with the seedproposals command to get proposals for all record statuses.
$ pictl seedproposals --comments=0 --commentvotes=0 [adminEmail] [adminPass]
The pictl voteinv response should be the same before and after the fsck.
This fixes a bug that was causing the vote status of non-public proposals to be returned incorrectly from the summary plugin command. The vote status was being returned as `unauthorized` when it should be `ineligible`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff adds a
fsckcommand for the ticketvote plugin. For everyrecord of the provided tokens, it:
Part of #1511