-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pi: Allow for billing status error correction. #1528
Conversation
@lukebp updated 💯 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm getting a pi summary 500 if I've updated the billing status more than once.
2021-10-07 10:50:41.375 [ERR] POLI: 127.0.0.1:34688 POST /v2/pluginreads HTTP/1.1 Internal error 1633621841: PluginRead pi summary : couldn't determine proposal status of an approved propsoal: billingStatus: 1
Fix the propsoal
typo in the error message too.
Fixed by introducing: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK
Just need to fix the formatting nit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK
Background:
Let's say an admin makes a mistake and sets the billing status to
completed when they actually meant to set it to closed. There should be
a way for them to correct this mistake.
We would like to enable error correction by adding a plugin setting
which limits the number of the allowed billing status changes. It
defaults to 1 and can be increased by a sysadmin in rare cases where a
billing status error correction is needed.
Implementation:
Adds
allowedbillingstatuschanges
pi plugin setting which defaultsto 1 and can be increased if a billing status error correction is
needed.
Adds in billing status validation that allows for the following state
transitions:
when the plugin setting allows for it.
Adds
active
status to thepictl proposalsetbillingstatus
command.Closes #1525.