Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pi: Add API to retreive billing status changes. #1526

Merged
merged 5 commits into from
Oct 4, 2021

Conversation

amass01
Copy link
Member

@amass01 amass01 commented Oct 2, 2021

Clients need to be able to retrieve the full billing status metadata so
that the admin username can be displayed and so that the admin signature
is available if the client wants it. In order to do this, API needs to
be added to the pi plugin for retrieving the full billing status change
metadata objects. With that said, the current StatusReason in not
needed in the pi Summary and can be removed as this feature wasn't
deployed to production yet.

Implementation:

  • Remove StatusReason from pi API Summary.
  • Add new /billingstatuschanges route to the pi API.
  • Add new pictl command pictl proposalbillingstatuschanges "token"
    command which consumes the new pi API.

Closes #1524.

@amass01 amass01 changed the title [wip] pi: Add API to retreive billing status changes. pi: Add API to retreive billing status changes. Oct 3, 2021
@amass01 amass01 marked this pull request as ready for review October 3, 2021 12:45
@amass01
Copy link
Member Author

amass01 commented Oct 3, 2021

@lukebp Ready for your review.

Copy link
Member

@lukebp lukebp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

Just the one typo.

politeiawww/cmd/pictl/cmdproposalbillingstatuschanges.go Outdated Show resolved Hide resolved
@lukebp lukebp merged commit 3a29738 into decred:master Oct 4, 2021
@amass01 amass01 deleted the billingstatuschanges branch October 4, 2021 13:51
@lukebp lukebp mentioned this pull request Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pi: Add API to retreive billing status changes.
2 participants