-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
politeiavoter: Migrate to new APIs. #1415
Conversation
inventory
to new APIs.inventory
to new APIs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_vote
calls _summary
which calls the old api to get proposal vote summary:
I would like to change this one in this PR as well.
Done, I've migrated the vote summaries call to call new API - see c104866, as result looks like all commands are now migrated and using the new APIs. Edit: One last todo https://github.com/decred/politeia/pull/1415/files#diff-9378a7dcd7429979890a5291a4310bab03060eadaf93e97974450ec07b83bd75R1504 - verify commands calls the vote results route and now it needs to call version and get the server pub key before in order to verify the response. |
inventory
to new APIs.
@lukebp updated. To test, I voted Update: Apparently for the |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and everything is working as expected. Just need to fix a few nits.
@lukebp Addressed. |
@lukebp updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK
@marcopeereboom will want to ok this.
Closes #1394.