politeiawww: Fix legacy pagination bug. #1397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Multiple legacy routes were previously returning 500s because the legacy API does not paginate properly in a lot of routes, but the politeiad v2 API expects the requests to be paginated, causing errors to occur. This diff updates the function that is used to request proposals from politeiad for the legacy routes to paginate the requests properly. It also updates the `pictl legacytest` command that tests the legacy routes to specifically test the pagination issue.
marcopeereboom
approved these changes
Apr 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple legacy routes were previously returning 500s because the legacy
API does not paginate properly in a lot of routes, but the politeiad v2
API expects the requests to be paginated, causing errors to occur.
This diff updates the function that is used to request proposals from
politeiad for the legacy routes to paginate the requests properly. It
also updates the
pictl legacytestcommand that tests the legacy routesto specifically test the pagination issue.