politiawww: Move sessions to userdb. #1113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This diff moves user sessions from a session store backed by the filesystem to a session store backed by the userdb. It implements a custom sessions store that satisfies the gorrilla/sessions Store interface. Moving the session store to the userdb accomplishes a few things: 1. Allows us to manually invalidate sessions. An example being when a user changes their password we can invalidate their sessions on all other devices. This was not previously possible with the filesystem store implementation. 2. Removes one of the blocking issues that is preventing us from running multiple politeiawww instances. This diff does not fix issues decred#647 or decred#650. It is a prerequisite for fixing those issues, but those issues will be fixed in the next PR.
lukebp
changed the title
marcopeereboom
approved these changes
Feb 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff moves user sessions from a session store backed by the
filesystem to a session store backed by the userdb. It implements a
custom sessions store that satisfies the gorrilla/sessions Store
interface.
Moving the session store to the userdb accomplishes a few things:
Allows us to manually invalidate sessions. An example being when a
user changes their password we can invalidate their sessions on all
other devices. This was not previously possible with the filesystem
store implementation.
Removes one of the blocking issues that is preventing us from running
multiple politeiawww instances.
This diff does not fix issues #647 or #650. It is a prerequisite for
fixing those issues, but those issues will be fixed in the next PR.