Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

www: Add vote status query param onto get vetted #622

Closed
lukebp opened this issue Nov 29, 2018 · 2 comments
Closed

www: Add vote status query param onto get vetted #622

lukebp opened this issue Nov 29, 2018 · 2 comments

Comments

@lukebp
Copy link
Member

lukebp commented Nov 29, 2018

When the proposals view initially loads it fetches a page of vetted proposals from politeiawww. The problem is that we list the proposals in the GUI by vote status, so despite the "pre-voting" tab showing that there are 12 pre-voting proposals, its possible that none of these proposals were in the original page of vetted proposals that were fetched from politeiawww. This means that navigating to the "pre-voting" tab would reveal a list of 0 proposals and would just show the "Load More" button. This is not ideal.

Adding an optional votestatus query param onto GET /proposals/vetted would allow the GUI to fetch a page of proposals of a certain vote status, ensuring that each tab of the proposals view is able to be populated correctly on initial load.

@victorgcramos
Copy link
Member

As we discussed on Slack, I'll be working on this issue from now.

@lukebp
Copy link
Member Author

lukebp commented Apr 15, 2019

#795 makes this no longer needed.

@lukebp lukebp closed this as completed Apr 15, 2019
vibros68 pushed a commit to vibros68/politeia that referenced this issue Aug 17, 2021
* Update helpers.js

1.Show the external domain more clearly. 
2.Change the warning message.

* Update helpers.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants