enhancement: Datepicker: Support dynamic range #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lukebp ready for review |
amass01
approved these changes
Nov 3, 2021
| @@ -195,7 +198,6 @@ const DatePicker = ({ | |||
| }, | |||
| [setLabelMonthsState, labelMonthsState] | |||
| ); | |||
|
|
|||
| @@ -40,6 +40,9 @@ const DatePicker = ({ | |||
| }) => { | |||
| const { themeName } = useTheme(); | |||
| const yearArr = useMemo(() => getYearArray(years), [years]); | |||
| useEffect(() => { | |||
There was a problem hiding this comment.
make the useEffect a named function with a meaningful name describing
what the useEffect does, i'd add a comment as well.
There was a problem hiding this comment.
Because inside the useEffect function has only 1 line of code. So I think would add comment is enough
amass01
reviewed
Nov 4, 2021
amass01
approved these changes
Nov 5, 2021
|
Needs approval from @tiagoalvesdulce. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #342
This diff makes the Datepicker change the range picker if the input of
the range is changed programly.
The video show the example of preview is below. In the video the max
date is increased 1 day every 5s
vokoscreen-2021-11-03_15-05-59.mp4