Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename package, add pay invoice form and update number of confirmations for a channel #8

Merged
merged 1 commit into from
Aug 6, 2019
Merged

Rename package, add pay invoice form and update number of confirmations for a channel #8

merged 1 commit into from
Aug 6, 2019

Conversation

fguisso
Copy link
Member

@fguisso fguisso commented Jul 10, 2019 •
edited
Loading

Rename package from lightning-faucet/main to lightning-faucet for a good install in $GOPATH

Add a Pay invoice form for simplify to users don't need to pay their invoices just in dcrlncli

Update wait six confirmations for create a new channel.

@fguisso fguisso changed the title Rename package and add payInvoice feature Rename package and add pay invoice form Jul 10, 2019
matheusd
matheusd requested changes Jul 10, 2019
View reviewed changes
Copy link
Member

@matheusd matheusd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add a guard against paying too many invoices (at most one per minute) and invoices of too large a value (use a max payment amount of 0.0001 or something).

faucet.go Outdated Show resolved Hide resolved
faucet.go Outdated Show resolved Hide resolved
faucet.go Outdated Show resolved Hide resolved
faucet.go Show resolved Hide resolved
faucet.go Outdated Show resolved Hide resolved
@matheusd
Copy link
Member

Also, please specify what your PR intends to do on its description.

@fguisso fguisso changed the title Rename package and add pay invoice form Rename package, add pay invoice form and update number of confirmations for a channel Jul 11, 2019
@fguisso
Copy link
Member Author

fguisso commented Jul 15, 2019

fixed

matheusd
matheusd reviewed Jul 17, 2019
View reviewed changes
Copy link
Member

@matheusd matheusd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to use full sentences on your comments. For example:

Verify inovoice amount.

vs

verify inovoice amount

faucet.go Outdated Show resolved Hide resolved
matheusd
matheusd reviewed Jul 18, 2019
View reviewed changes
faucet.go Outdated Show resolved Hide resolved
matheusd
matheusd reviewed Jul 30, 2019
View reviewed changes
static/index.html Outdated Show resolved Hide resolved
faucet.go Show resolved Hide resolved
faucet.go Outdated Show resolved Hide resolved
static/index.html Outdated Show resolved Hide resolved
faucet.go Outdated Show resolved Hide resolved
matheusd
matheusd approved these changes Jul 31, 2019
View reviewed changes
Copy link
Member

@matheusd matheusd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash and rebase against the latest master so I can merge it.

@fguisso
multi: add pay invoice form, update infos
1fb8968 
Add a payment invoice form in the service faucet.go
and update the static files to show this feature.

Rename package to avoid install a bin with name main.

Update confirmations to wait in channel creation.
@matheusd matheusd merged commit 1fb8968 into decred:master Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matheusd matheusd matheusd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fguisso @matheusd