Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve VSPSelect usability and responsivity #3563

Merged

Conversation

guilhermemntt
Copy link
Contributor

This PR improves the responsivity of the VSPSelect and AutoBuyerSettingsModal components by:

  • Stretching the account select to adjust the modal width.
  • Enabling clicks on the right corner of a VSP option (currently, there's a padding inserted by react-select).
  • Inserting ellipsis on long VSP host names.

Also, the small "close" icon should clear the current input only when typing, since it's useless for clearing the selected VSP.

Copy link
Collaborator

@bgptr bgptr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice. I found only one thing: the tooltips disappeared.

This is how it looks like on master now:
2021-09-30_10-50

@guilhermemntt
Copy link
Contributor Author

Hey @bgptr, thanks for the review. That last commit solves the issue by detaching the text-overflow from the relative component.

Copy link
Collaborator

@bgptr bgptr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @guilhermemntt Perfect, the tooltips are back. Thanks!

@alexlyp alexlyp merged commit 0a99a17 into decred:master Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants