Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify layout breakpoints #3525

Merged
merged 18 commits into from
Jul 13, 2021
Merged

Simplify layout breakpoints #3525

merged 18 commits into from
Jul 13, 2021

Conversation

bgptr
Copy link
Collaborator

@bgptr bgptr commented Jul 1, 2021 •
edited
Loading

In this diff, the layout breakpoints simplified to:

  • 560px
  • 768px
  • 1000px
  • 1180px (decrediton specific breakpoint)

Additional wide screen breakpoints introduced by #2412:

  • 1400px (although in the design 1440px is defined, 1400px is more compatibe with pigui)
  • 1680px
  • 1920px

Fixed a couple of layout problems also:

  • testnet logo on small screens
  • transaction confirmation modal
  • privacy options on small screens
  • next button height on the tutorial page

Closes #3309

bgptr added 18 commits June 30, 2021 21:47
@bgptr
1179px -> 1180px
1361990
@bgptr
ReleaseNotes (1140px -> 1180px, 890px > 1000px)
d86bcd3
@bgptr
1106px -> 1180px
7391541 
+ TransactionContent  css cleanup
+ TitleHeader container's width correction
@bgptr
978px > 1000px + improve layout of Privacy Options page
0f740b6
@bgptr
fix testnet logo on smaller screen sizes
8fb7c92
@bgptr
improve layout of Transaction Confirmation modal
4140926
@bgptr
fix height of the next button on tutorial page
33414fb
@bgptr
955px -> 1000px, 588px -> 560px
27c1e9f 
+ improve about modal on smaller screen
@bgptr
Improve (simplify) Tutorial Page layout
e1089a5 
(460px, 500px. 541px, 670px, 700px, 768px, 916px) -> (560px, 768px, 1000px)
@bgptr
improve TutorialsPage layout
41de030 
+ fix close button position
+ 800px -> 768px
@bgptr
modals
8048125 
+ 375px -> 560px
+ 420px -> 560px
+ improve Indo modal layout
@bgptr
breakpoints for dangerButton seems unnecessary
4b7136b
@bgptr
breakpoints for KeyBlueButton seems unnecessary
ba63a84
@bgptr
765px -> 768px
8b167ad
@bgptr
improve Settings layout
ccb7d7a 
+ 1919px -> 1920px
+ 1679px -> 1680px
+ 1439px -> 1400px (not 1440px, but 1400px which is more compatible with pigui)
+ polish  layout of elements
+ remove 676px breakpoint
@bgptr
improve Logs page
3023663 
+ remove 375px 
+ 430px => 560px
@bgptr
cleanup
ce6d36c
@bgptr
satisfy test
41acd92
@alexlyp alexlyp merged commit e12b0fe into decred:master Jul 13, 2021
@bgptr bgptr deleted the simplify-breakpoints branch August 27, 2021 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matheusd matheusd matheusd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[dex integration] Define strict layout breakpoints.
3 participants
@bgptr @matheusd @alexlyp