-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List UTXO’s modal #3323
List UTXO’s modal #3323
Conversation
looks mostly good. Only issue I notice is in dark mode the font colors look a little off and the top bar (that has UTXO and Value) is not colored correctly. |
I also think it's worth matching the minimum spacing on the top and bottom of the modal to match the sides. Seems a little tight on the top and bottom, 20 px seems like a good amount of margin/padding there |
@alexlyp Thanks for the review. I've improved the colors in dark mode, but I am not sure about your margin/padding comment. Could you attach a screenshot? |
Can't unfortunately. But basically I'm see the top and bottom of the modal come too close to the very edge of the electron window. Feel like that space should be wider. |
@alexlyp Now I see what you mean. I've improved the spacing. |
Ah much better thanks for the update @bgptr |
Closes #3281 and #3321