Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List UTXO’s modal #3323

Merged
merged 8 commits into from
Mar 22, 2021
Merged

List UTXO’s modal #3323

merged 8 commits into from
Mar 22, 2021

Conversation

bgptr
Copy link
Collaborator

@bgptr bgptr commented Mar 19, 2021

Closes #3281 and #3321

@alexlyp
Copy link
Member

alexlyp commented Mar 22, 2021

looks mostly good. Only issue I notice is in dark mode the font colors look a little off and the top bar (that has UTXO and Value) is not colored correctly.

@alexlyp
Copy link
Member

alexlyp commented Mar 22, 2021

I also think it's worth matching the minimum spacing on the top and bottom of the modal to match the sides. Seems a little tight on the top and bottom, 20 px seems like a good amount of margin/padding there

@bgptr
Copy link
Collaborator Author

bgptr commented Mar 22, 2021

@alexlyp Thanks for the review. I've improved the colors in dark mode, but I am not sure about your margin/padding comment. Could you attach a screenshot?

@alexlyp
Copy link
Member

alexlyp commented Mar 22, 2021

Can't unfortunately. But basically I'm see the top and bottom of the modal come too close to the very edge of the electron window. Feel like that space should be wider.

@bgptr
Copy link
Collaborator Author

bgptr commented Mar 22, 2021

@alexlyp Now I see what you mean. I've improved the spacing.

@alexlyp
Copy link
Member

alexlyp commented Mar 22, 2021

Ah much better thanks for the update @bgptr

@alexlyp alexlyp merged commit be055e9 into decred:master Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List UTXO’s view / modal update
2 participants