-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates Staking Tab names #3219
Conversation
@dezryth Thanks for bringing this to the table. My thoughts from matrix chat room: These indeed read better than current labels, just thought as we already changed this page title and it's menu item label Something like: |
Updates Tickets Status to Ticket Status. Updates History Tickets to Ticket History.
8287a05
to
3d0d33a
Compare
@amassarwi I personally feel inclusion of the word "Ticket" in most of these tab names is the most appropriate as the tabs display information on ticket purchasing and tickets purchased by the wallet, while "Stake/Staking" will lead to a little more mental gymnastics to understand what the context is. Perhaps more importantly, since Tickets are a huge differentiator for Decred as opposed to other cryptocurrencies that have PoS as part of their consensus and "Staking", I think it's important for us to keep the term "Ticket" around somewhat prominently. This is my opinion, but interested to hear what others think. I don't feel too strongly about it one way or the other. |
I'm fine with both, was just a suggestion. |
Please mention the issue linked to this PR in the description above. See github docs for linking issues with PRs - after doing so, merging the PR successfully will automatically close the |
Closes #3218
Updates Tickets Status to Ticket Status.
Updates History Tickets to Ticket History.