Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates Staking Tab names #3219

Merged
merged 2 commits into from
Feb 17, 2021
Merged

Conversation

dezryth
Copy link
Contributor

@dezryth dezryth commented Feb 14, 2021

Closes #3218

Updates Tickets Status to Ticket Status.
Updates History Tickets to Ticket History.

image

app/i18n/translations/original.json Outdated Show resolved Hide resolved
@amass01
Copy link
Member

amass01 commented Feb 14, 2021

@dezryth Thanks for bringing this to the table.

My thoughts from matrix chat room:

These indeed read better than current labels, just thought as we already changed this page title and it's menu item label
from Tickets to Staking lately maybe we should use it also in tabs labels.

Something like: Stake, Staking Status, Staking History & Statistics ?

Updates Tickets Status to Ticket Status.
Updates History Tickets to Ticket History.
@dezryth
Copy link
Contributor Author

dezryth commented Feb 15, 2021

@amassarwi I personally feel inclusion of the word "Ticket" in most of these tab names is the most appropriate as the tabs display information on ticket purchasing and tickets purchased by the wallet, while "Stake/Staking" will lead to a little more mental gymnastics to understand what the context is. Perhaps more importantly, since Tickets are a huge differentiator for Decred as opposed to other cryptocurrencies that have PoS as part of their consensus and "Staking", I think it's important for us to keep the term "Ticket" around somewhat prominently. This is my opinion, but interested to hear what others think. I don't feel too strongly about it one way or the other.

@amass01
Copy link
Member

amass01 commented Feb 15, 2021

I'm fine with both, was just a suggestion.

@amass01
Copy link
Member

amass01 commented Feb 15, 2021

Please mention the issue linked to this PR in the description above.

See github docs for linking issues with PRs - after doing so, merging the PR successfully will automatically close the
linked issue.

@alexlyp alexlyp merged commit 2f79668 into decred:master Feb 17, 2021
alexlyp pushed a commit that referenced this pull request Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Staking Tab - "History Tickets" and "Tickets Status" name change
4 participants