-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove noUiSlider and use pi-ui one #3046
Conversation
You may know it already but you can yarn link local packages to develop locally, run |
6a4dc07
to
642853a
Compare
Thanks for your suggestion @tiagoalvesdulce! Luckily, just small changes have been required to fit |
@@ -286,8 +286,7 @@ | |||
"mv": "^2.1.1", | |||
"node-abi": "^2.15.0", | |||
"node-addon-loader": "decred/node-addon-loader#master", | |||
"nouislider": "^12.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR, looking good, but I believe I am hitting an infinite loading which makes my computer really slow if I play a bit with the slider
Well, thanks for the feedback @vctt94, I'll take a look. |
It seems it's possible to achieve better performance using |
df4f429
to
8bf7c99
Compare
Rebased. |
I am getting errors when trying to run this with
|
Thanks for testing this one @jholdstock. Could not reproduce this warning here. Are you sure you reinstalled the dependencies using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was it, it works after running yarn
. Looks good and works well.
The performance is absolutely appalling when loading transactions - the app becomes unresponsive, CPU spins, and animations chug, but that is a known issue which is noted elsewhere, and not related to this PR.
8bf7c99
to
197a4a1
Compare
Replace old slider by pi-ui slider
82bc2b0
to
93b76d9
Compare
Rebased. |
package.json
Outdated
@@ -286,8 +286,7 @@ | |||
"mv": "^2.1.1", | |||
"node-abi": "^2.15.0", | |||
"node-addon-loader": "decred/node-addon-loader#master", | |||
"nouislider": "^12.0.0", | |||
"pi-ui": "https://github.com/decred/pi-ui", | |||
"pi-ui": "https://github.com/guilhermemntt/pi-ui#50b040d1ea0a5e83f6d2fd9d9f3a970282f23320", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a NACK for me. Needs to be in a decred owned repo. Or someone with longer standing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, @alexlyp, sorry. Guys at pi-ui
will merge my PR there as soon this one here is approved, but I can talk to them. So I can use the master pi-ui
repo and we can finally merge it if it's ok.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK now that it's merged in pi-ui, please go ahead and remove this change and then should be good to go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done! Thanks @alexlyp
package.json
Outdated
@@ -286,7 +286,8 @@ | |||
"mv": "^2.1.1", | |||
"node-abi": "^2.15.0", | |||
"node-addon-loader": "decred/node-addon-loader#master", | |||
"pi-ui": "https://github.com/guilhermemntt/pi-ui#50b040d1ea0a5e83f6d2fd9d9f3a970282f23320", | |||
"nouislider": "^12.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should go away
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done! Thanks!
705c8b8
to
494f4c8
Compare
This PR is a PoC of decred/pi-ui#308. It will solve #2874 when approved. For while,
pi-ui
dependence inpackage.json
has been changed to my forked repository, butpackage.json
changes will be discarded after the merge in the officialpi-ui
repo.